Skip to content

fix: OPTIC-945: Improve the bundling strategy and ship a single entrypoint with a common vendor chunk across all libs - revert #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: OPTIC-945: Improve the bundling strategy and ship a single entrypoint with a common vendor chunk across all libs - revert #6198

merged 1 commit into from
Aug 13, 2024

Conversation

yyassi-heartex
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

reverting the changes to allow customers to update their configs where affected

@yyassi-heartex
revert: OPTIC-945: Improve the bundling strategy and ship a single en…
cfe31cf 
…trypoint with a common vendor chunk across all libs
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit cfe31cf
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66bb8a9bf2b442000880ff8c

@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit cfe31cf
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66bb8a9b88c79300082679a6

@yyassi-heartex yyassi-heartex enabled auto-merge (squash) August 13, 2024 16:38
amymrou
amymrou approved these changes Aug 13, 2024
View reviewed changes
Copy link

@amymrou amymrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is revert, LGTM

@yyassi-heartex yyassi-heartex changed the title revert: OPTIC-945: Improve the bundling strategy and ship a single entrypoint with a common vendor chunk across all libs fix: OPTIC-945: Improve the bundling strategy and ship a single entrypoint with a common vendor chunk across all libs - revert Aug 13, 2024
@yyassi-heartex yyassi-heartex merged commit 9997158 into develop Aug 13, 2024
38 of 39 checks passed
yyassi-heartex added a commit that referenced this pull request Aug 13, 2024
@yyassi-heartex
Revert "revert: OPTIC-945: Improve the bundling strategy and ship a s…
0cf9577 
…ingle entrypoint with a common vendor chunk across all libs (#6198)"

This reverts commit 9997158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlomzik hlomzik hlomzik approved these changes

@amymrou amymrou amymrou approved these changes

Assignees
No one assigned
Labels
fix title needs formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yyassi-heartex @hlomzik @amymrou